Add composer scripts #1120
Add composer scripts #1120
Conversation
GromNaN
force-pushed
the
composer-scripts
branch
from
060f3e5 to
4512f99
Compare
GromNaN
force-pushed
the
composer-scripts
branch
from
4512f99 to
4fc4176
Compare
CONTRIBUTING.md
Outdated
| @@ -47,7 +47,7 @@ By default, the `simple-phpunit` binary chooses the correct PHPUnit version for | |||
| the PHP version you are running. To run tests against a specific PHPUnit | |||
| version, use the `SYMFONY_PHPUNIT_VERSION` environment variable: | |||
|
|
|||
| ``` | |||
| ```console | |||
| $ SYMFONY_PHPUNIT_VERSION=7.5 vendor/bin/simple-phpunit | |||
There was a problem hiding this comment.
I realize this is outside the PR scope, but it's a good opportunity to bump this to a later version. Given https://phpunit.de/supported-versions.html, I don't think anything older than 8.5 would be used in practice.
Alternatively, we can remove this example and just link to https://symfony.com/doc/current/components/phpunit_bridge.html#modified-phpunit-script for canonical documentation.
|
|
||
| The library uses [rector](https://getrector.com/) to refactor the code for new features. | ||
| To run automatic refactoring, use the `rector` command: | ||
|
|
||
| ``` | ||
| ```console | ||
| $ vendor/bin/rector |
There was a problem hiding this comment.
Did you mean to change this to the fix: or check: command? Or are you intentionally calling the original binary here?
There was a problem hiding this comment.
I really hesitated. In the end, I think we should offer the 2 entry points into the document: Composer scripts in the header and the path to the binaries in details.
Ease dev process by adding shortcuts to the common commands.
Also adding me to the authors of the library, not because I've deleted almost as many lines as I've added, but because it's become my full-time activity.